Nordic nRF54H refactor default power domain handling #97452
Draft
+80
−468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All devices used in their "normal"/intended configuration do not require management of the power domains, as the hardware itself will request them automatically. Thus by default, don't specify the power domains to avoid redundant resume/suspend cycles, which are slow and require threading (IPC) making devices not isr ok. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
The gpio pad groups are redundant if pin retention is handled per pin, and the quirky cross domain feature is managed by the application. Remove it entirely. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
GPIO pad power domain management is not neccesary if the quirky cross domain feature is handled at the application level. Replace it with directly setting/clearing pin retention, as hardware will force power domains on automatically. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Replace the pad group integration with directly setting/clearing pin retention for output pins if required, since the pad group integration is redundant if the quirky cross domain feature is managed by the application. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
changed the title
bjarki-andreasen
changed the title
Devices which use AIN (COMP, LPCOMP, SAADC) don't use pinctrl to configure their pins, thus pinctrl can't manage pin retention like is done for other devices. Thus for now, add manually disabling pin retention to the drivers. In the future, we should probably use pinctrl for these inputs as well, at which point this commit can be reverted. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
nrf54h-refactor-quirks
branch
from
4b40ddd to
d8f3ca9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardware in the nRF54H is designed to automatically handle power domains by default. There are quirky configurations that can be used which require additional management of power domains, but these are uncommon and must be managed from the application in most cases. This PR makes the common cases the default, which is more efficient and provides better flexibility to the application, while still allowing for the quirky configurations to be managed from the application if that is required.